missing close tag in Compiler/Backend/DumpXML.mo

Index
» Developer
» OpenModelica development
» missing close tag in...

Page Start Prev 1 Next End

- Subscribe

missing close tag in Compiler/Backend/DumpXML.mo

#1963 Permalink

missing close tag in Compiler/Backend/DumpXML.mo

Feb-05-12 23:34:17

I noticed that the code to handle MathML tags is missing the emit of a close tag. Here's a patch.

Bill

Code:


Index: Compiler/BackEnd/XMLDump.mo

===================================================================

--- Compiler/BackEnd/XMLDump.mo    (revision 11031)

+++ Compiler/BackEnd/XMLDump.mo    (working copy)

@@ -1700,6 +1700,7 @@

         dumpStrOpenTag(MathMLElseBranch);

         dumpExp2(fb);

         dumpStrCloseTag(MathMLElseBranch);

+        dumpStrCloseTag(MathMLIfClause);

         dumpStrCloseTag(MathMLApply);

       then ();

     case (DAE.CALL(path = Absyn.IDENT(name = "der"),expLst = args))

Edited by: janssen - Feb-06-12 21:24:29

janssen: 45 Posts; Thank you [ 0 ]

#1966 Permalink

Re: missing close tag in Compiler/Backend/DumpXML.mo

Feb-07-12 17:08:39

Thank you for the patch, I have applied it to our trunk in revision 11042.

perost: 114 Posts; Thank you [ 12 ]

#1975 Permalink

Re: missing close tag in Compiler/Backend/DumpXML.mo

Feb-09-12 17:27:00

All the opening XML tags in the _init.xml files are missing their closing bracket, too, like the "ScalarVariable" tag in this snippet:

<ScalarVariable
name = "pendel2.x0"
valueReference = "1026"
description = "x-Position des Lagers in m"
...
</ScalarVariable>

Latest Release version, 1.8.1

That's not supposed to be missing, is it? Same cause as the issue mentioned in the initial post?

dael: 14 Posts; Thank you [ 0 ]

#1979 Permalink

Re: missing close tag in Compiler/Backend/DumpXML.mo

Feb-09-12 17:48:51

I don't have any missing end tags for elements in _init.xml. Everything is properly closed.
How do you get this? Do you have a model?

Code:


<ScalarVariable

    name = "y"

    valueReference = "1000"

    variability = "continuous" isDiscrete = "false"

    causality = "internal"

    alias = "noAlias"

    classIndex = "0" classType = "rSta"

    fileName = "ArrayEqn.mo" startLine = "16" startColumn = "3" endLine = "16" endColumn = "23" fileWritable = "true">

    <Real start="1.0" fixed="true"  />

  </ScalarVariable>

Cheers,
Adrian Pop/

adrpo: 885 Posts; Thank you [ 141 ]

#1980 Permalink

Re: missing close tag in Compiler/Backend/DumpXML.mo

Feb-09-12 17:50:32

Hi Adrpo,

But the code you posted has the same thing. Isn't the "Scalarvariable" opening tag supposed to have < in front and > at the end? Or am I wrong about what XML is supposed to look like?

As in:

Code:


<ScalarVariable>

    name = "y"

    ...

dael: 14 Posts; Thank you [ 0 ]

#1981 Permalink

Re: missing close tag in Compiler/Backend/DumpXML.mo

Feb-09-12 17:51:45

No, name, etc are attributes of the tag.

Code:

<tagName attr=value>

</tagName>

sjoelund.se: 1700 Posts; Thank you [ 159 ]

#1982 Permalink

Re: missing close tag in Compiler/Backend/DumpXML.mo

Feb-09-12 17:51:52

Hi,

But it does, after all the attributes, before = "true" >.

Cheers,
Adrian Pop/

adrpo: 885 Posts; Thank you [ 141 ]

#1983 Permalink

Re: missing close tag in Compiler/Backend/DumpXML.mo

Feb-09-12 17:54:10

Oops! Now I see it too.

My text editor highlighted everything that came after "<ScalarVariable" with red and I did not notice the closing >. so I thought there was something wrong with the XML.

Sorry!

dael: 14 Posts; Thank you [ 0 ]

#1989 Permalink

Re: missing close tag in Compiler/Backend/DumpXML.mo

Feb-11-12 00:27:08

Yeah, you really need to look at it with an XML editor, not a text editor.

janssen: 45 Posts; Thank you [ 0 ]

#1991 Permalink

Re: missing close tag in Compiler/Backend/DumpXML.mo

Feb-11-12 21:16:46

I just checked on Wikipedia for free XML editors, and "CAM editor" as well as "Serna XML" came up high on their lists.

Can you recommend either one, or another freely available XML editor?